Fix bug causing AnimatedValue to freeze after same value is entered #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be a bug in `Dashing.AnimatedValue` which causes the AnimatedValue to freeze if the new value is equal to the current. The source of the bug seems to be due to the comparison in `num == to` being between a float and a string. By default, CoffeeScript compiles `==` to Javascript's `===`. Instead, if we use backticks, we can use a "raw Javascript" command which allows us to call `==`.
kinow
approved these changes
May 22, 2020
| @@ -96,7 +96,7 @@ Dashing.AnimatedValue = | |||
| else | |||
| timer = "interval_#{k}" | |||
| num = if (!isNaN(@[k]) && @[k]?) then @[k] else 0 | |||
| unless @[timer] || num == to | |||
| unless @[timer] || `num == to` | |||
There was a problem hiding this comment.
@femtogram what about moving the parseFloat to before this line? Otherwise, I think we should leave a comment here so that other developers don't accidentally remove the backticks, and to help if moving away from coffeescript later and having to rewrite this code (see #72). WDYT?
There was a problem hiding this comment.
Oh gee, completely missed this. Yes, I think moving the parseFloat was probably the better solution, but I see you've added the change with the note! With a rewrite the note might be helpful to prevent the same bug moving forward.
kinow
added a commit
that referenced
this pull request
Jun 3, 2020
|
Added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a bug in
Dashing.AnimatedValuewhich causes theAnimatedValue to freeze if the new value is equal to the current. The
source of the bug seems to be due to the comparison in
num == tobeing between a float and a string. By default, CoffeeScript compiles
==to Javascript's===. Instead, if we use backticks, we can use a"raw Javascript" command which allows us to call
==.