Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurrentModFileCount and TotalModFileCount variables bug #262

Open
MeTonaTOR opened this issue Nov 1, 2023 · 0 comments
Open

CurrentModFileCount and TotalModFileCount variables bug #262

MeTonaTOR opened this issue Nov 1, 2023 · 0 comments

Comments

@MeTonaTOR
Copy link
Contributor

There seems to be an issue on counting the files to be downloaded, count doesnt vanish to be precise as of video: https://www.youtube.com/watch?v=H_0G60JzeJk (file too big to be uploaded via Issues page)

Quickest steps to reproduce:

  • Delete MODS folder
  • Select first server (ie NRZ)
  • Login and Download ModNet files
  • taskkill /im nfsw.exe /f
  • Do not close launcher, just press logout
  • Select different server (ie FRSS)
  • Login and Download ModNet files

You will notice that the total ModNet files to be downloaded are a sum of files from NRZ and FRSS (as of Steps to Reproduce)

Possible fix:

According to this file, all we have to do is set CurrentModFileCount and TotalModFileCount to 0, like:

if (modFilesDownloadUrls.Count != 0)
{
    CurrentModFileCount = 0;
    TotalModFileCount = 0;
    this.DownloadModNetFilesRightNow(ModFolderCache);
    DiscordLauncherPresence.Status("Download Server Mods", null);
}

Debug:

  • Launcher Version: 2.2.2 (but any version is affected actually)
  • Operating system: Windows 11 Pro (22621.2506)
  • Antivirus/Firewall (if any): None
  • Wine/Mono Version (if any): Not on that machine
DavidCarbon added a commit to Zacam/SBRW.Launcher.Net that referenced this issue Nov 1, 2023
Fixed:
- Server Mods File Download Count would fail to display correctly if the game crashed and returned to the login screen. In turn switching to another server and redownloading switched server mods
-- SoapboxRaceWorld#262
DavidCarbon added a commit to DavidCarbon-SBRW/GameLauncher_NFSW that referenced this issue Nov 1, 2023
Fixed:
- Server Mods File Download Count would fail to display correctly if the game crashed and returned to the login screen. In turn switching to another server and redownloading switched server mods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant