add tests for blobby_kernel #269
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SolidHal
This adds tests for the blobby kernel (both armhf/arm64).
Note that it requires a makefile fix: currently calling 'make kernel' (or blobby_kernel) fails in a clean tree, because filesystem is required, but not called first. I added a commit to depend on filesystem first. Alternatively, the makefile targets could be adjusted, or maybe some other approach. I'll leave that to your judgement, the important thing is that 'make kernel|blobby_kernel' should work out of the box (or if not, IMO, we need a good reason, and in any event, we'll need to adjust the github action/build scripts accordingly, but that's relatively minor).