Don't leak wireless password into shell history #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin987
reviewed
Jan 13, 2021
| @@ -251,7 +251,7 @@ Congratulations: you are done! Welcome to PrawnOS. You should probably change th | |||
| If have a basic environment without xfce or lxqt you can connect to WiFi using `nmtui` and it's menus to connect; or issue the following nmcli commands: | |||
| ``` | |||
| nmcli device wifi list | |||
| nmcli device wifi connect "Network_name" password "network_password" | |||
| nmcli --ask device wifi connect "Network_name" # The --ask will prompt you for the password so it doesn't remain in your shell history | |||
There was a problem hiding this comment.
IMO the comment is superfluous (--ask is pretty self explanatory).
I'd also suggest prefacing the commit with 'README:' to make git log more readable.
There was a problem hiding this comment.
nmtui-connect will show a fancy screen with wifi network selection, maybe it should be used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.