Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display notification if compatible NodeJS not found #3175

Closed
duncanp-sonar opened this issue Aug 11, 2022 · 0 comments
Closed

Display notification if compatible NodeJS not found #3175

duncanp-sonar opened this issue Aug 11, 2022 · 0 comments
Assignees
@duncanp-sonar
Labels
Language - JS/TS JavaScript or TypeScript Type: Improvement
Milestone
6.8

Comments

@duncanp-sonar
Copy link
Contributor

duncanp-sonar commented Aug 11, 2022 •
edited
Loading

Description

A notification should be displayed if JS/TS analysis cannot be performed because an appropriate version of NodeJS cannot be found.

The notification should contain a link to more information that explains the problem and how to fix it.

The user should be able to:

  • dismiss the current notification
  • indicate that they do not want to see the notification again.

TODO - should the notification only be displayed for every file, or only once per VS session?
UPDATE: a total of once per VS session (i.e. if shown only once even if both JS and TS are analysed).
@duncanp-sonar duncanp-sonar added Type: Task Language - JS/TS JavaScript or TypeScript labels Aug 11, 2022
@duncanp-sonar duncanp-sonar added this to the Update analyzers milestone Aug 11, 2022
@duncanp-sonar duncanp-sonar self-assigned this Aug 23, 2022
duncanp-sonar added a commit that referenced this issue Aug 23, 2022
@duncanp-sonar
Call Node notification service if compatible version not found
3cfe870 
Fixes #3175
@duncanp-sonar duncanp-sonar mentioned this issue Aug 23, 2022
Merged
duncanp-sonar added a commit that referenced this issue Aug 23, 2022
@duncanp-sonar
Call Node notification service if compatible version not found (#3211)
374c6cd 
* Call Node notification service if compatible version not found

Fixes #3175
duncanp-sonar added a commit that referenced this issue Aug 31, 2022
@duncanp-sonar
Call Node notification service if compatible version not found (#3211)
91f72d5 
* Call Node notification service if compatible version not found

Fixes #3175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duncanp-sonar duncanp-sonar

Labels
Language - JS/TS JavaScript or TypeScript Type: Improvement
Projects
None yet
Milestone
6.8
Development

No branches or pull requests
1 participant
@duncanp-sonar