Accept custom schemas via a ZodSchema() method #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New examples are included in the custom/ directory.
Southclaws
approved these changes
Dec 13, 2023
|
Really nice, thanks! |
josiah-tt
added a commit
to token-transit/supervillain
that referenced
this pull request
Jan 10, 2024
PRs Southclaws#10 and Southclaws#11 added reflection-based checks for interface implementations (internal interfaces defining a ZodSchema() methods, and the json.Marshaler interface). But since ConvertType() unwraps pointers before proceeding with conversion, and the underlying type does not implement the interface if the method was defined with a pointer receiver, we did not detect interface implementations using pointer receivers. This change addresses that problem by checking reflect.Implements() both for the type directly and for a pointer to the type.
josiah-tt
added a commit
to token-transit/supervillain
that referenced
this pull request
Jan 10, 2024
PRs Southclaws#10 and Southclaws#11 added reflection-based checks for interface implementations (internal interfaces defining a ZodSchema() methods, and the json.Marshaler interface). But since ConvertType() unwraps pointers before proceeding with conversion, and the underlying type does not implement the interface if the method was defined with a pointer receiver, we did not detect interface implementations using pointer receivers. This change addresses that problem by checking .Implements() both on the type directly and on a pointer to the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a centralized map of custom schema functions to
NewConverter()separates the custom schema definition from its type. Sometimes this is necessary (as in theshopspring/decimal.Decimalexample), but when the supervillain user has control over the type that needs a custom schema, it's nicer to define a method that returns the schema.New examples are included in the custom/ directory.