Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update librespot dependencies #1301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lordievader
Copy link

Spotifyd fails to load encrypted files. This seems to be related to changes on Spotify's end. The librespot v0.4.2 release blacklists a few access points that caused librespot to fail playback anything. This change points the librespot v0.4.2 to address similar issues.

Fixes #1300 and #1299.

Note: I'm not a Rust developer, I'm not sure if the changes to Cargo.lock are really necessary. All I did was a cargo update after modifying the Cargo.toml.

@eladyn
Copy link
Member

eladyn commented Sep 5, 2024

Thank you for the contribution! I'm a little confused, since in v0.3.5, the librespot version we were using, was already at 0.4.2. So this should not actually change anything. (the version spec 0.4 includes semver compatible versions like 0.4.2).

See here for one of the Cargo.lock lines at that time.

@klh
Copy link

klh commented Sep 7, 2024

Confirmation on this, this solves the issues

@klh
Copy link

klh commented Sep 7, 2024

Thank you for the contribution! I'm a little confused, since in v0.3.5, the librespot version we were using, was already at 0.4.2. So this should not actually change anything. (the version spec 0.4 includes semver compatible versions like 0.4.2).

See here for one of the Cargo.lock lines at that time.

Librespot pulled version 0.4 perhaps there some fudging with cargo due to that

@lordievader
Copy link
Author

Thank you for the contribution! I'm a little confused, since in v0.3.5, the librespot version we were using, was already at 0.4.2. So this should not actually change anything. (the version spec 0.4 includes semver compatible versions like 0.4.2).

See here for one of the Cargo.lock lines at that time.

How strictly does cargo respect the Cargo.lock? Suppose librespot 0.4.0 was installed before the update to 0.4.2. Afterwards the Cargo.lock was updated to 0.4.2. Does cargo force an update to 0.4.2 or would the installed 0.4.0 suffice as it matches 0.4? If it does not it would explain why setting the dependency to 0.4.2 explicitly solves the issue.

Spotifyd fails to load encrypted files. This seems to be related to
changes on Spotify's end. The librespot v0.4.2 release blacklists a few
access points that caused librespot to fail playback anything. This
change points the librespot v0.4.2 to address similar issues.
@lordievader
Copy link
Author

Seeing as the librespot dependencies in Cargo.lock are already on 0.4.2 and running cargo update would increase the base rust version beyond what the CI supports I've dropped the Cargo.lock changes.

In my quick test this still solves the problem, but has a better chance of passing the CI.

@eladyn
Copy link
Member

eladyn commented Sep 10, 2024

Have you tried compiling the current master without the Cargo.toml changes? In this case, we could just do a new release and things would work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotifyd crash on track loading
3 participants