Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stellarity incompatibility (wont fix) #53

Closed
SrRapero720 opened this issue May 4, 2024 · 2 comments
Closed

Stellarity incompatibility (wont fix) #53

SrRapero720 opened this issue May 4, 2024 · 2 comments
Labels
Categoty: Mod incompatibilty Causes by other mod. Severity: High Requieres special atencion to be fixed at least was possible Status: Wontfix This will not be worked on Type: Bug Something isn't working

Comments

@SrRapero720
Copy link
Owner

This Issue for the record

Stellarity is a datapack made by @kohy-creates which adds a bunch of stuff on the end dimension.

Cause

The author for some unexplained reason decides to modify the minecraft core tex_color shader using the resourcepack of the datapack
https://github.com/kohy-creates/Stellarity/blob/master/resource_pack/assets/minecraft/shaders/core/position_tex_color.fsh

This shader is used by WaterFrames, LittleFrames and VideoPlayer. With this modification, those mods lost the capability of modify the shader color and the transparency and of course picture got rotated (depending on the direction) and cropped.

Solution

Nothing on the listed mods side can be done to fix the incompatibility.
This needs to be addressed by the Stellarity author, removing that shader override or fixing it

Precautions

To avoid users install both mods and get confused of why WF isn't working properly (and not forcing them to break their worlds removing one of the mods later) waterframes will throw an exception when stellarity is installed, indicating the reason and forcing the user to remove waterframes or remove stellarity before deploy their worlds to producction

@SrRapero720 SrRapero720 added Type: Bug Something isn't working Status: Wontfix This will not be worked on Severity: High Requieres special atencion to be fixed at least was possible Categoty: Mod incompatibilty Causes by other mod. labels May 4, 2024
@SrRapero720 SrRapero720 closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
@SrRapero720 SrRapero720 pinned this issue May 19, 2024
SrRapero720 added a commit that referenced this issue Aug 19, 2024
- use own-made RenderType
- uses now Translucent vertex format and ShaderInstance
- Refactored few classes
- Fixes minor memoryleak on deusing video's ImageCache
- Fixed #53
- code refator
@SrRapero720
Copy link
Owner Author

This issue has been "fixed", whoever, i keep the stellarity crash even on modern versions by 2 reasons

  • No interest from the stellarity author to fix + backport the issue fix
  • Other mods such as LittleFrames and VideoPlayer are still affected.

VideoPlayer includes now their custom crashes and LittleFrames has pending add it.
And no, new renderer cannot be ported to these mods because it was a little bit experimental and behavior cross-versions is unknowed. not even mentioning the 1.18.2~1.21.1 support range

@uczpre

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Categoty: Mod incompatibilty Causes by other mod. Severity: High Requieres special atencion to be fixed at least was possible Status: Wontfix This will not be worked on Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants