Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix view controller containment #24

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ankorko
Copy link

@ankorko ankorko commented Mar 28, 2015

My proposed fix for #23. Besides using the View Controller Containment APIs, I have made the internal UIScrollview fullscreen, so that it extends behind the bar iOS 7 style.

@confile
Copy link

confile commented Apr 19, 2015

+1 hope this gets merged soon

@harkmall
Copy link

+1 please merge this

@rodericj
Copy link
Contributor

Great change. This fixed a problem I was having when the SLPagingView's willDisappear was called. I'm going to look more into this one.

@dereck009
Copy link

+1

@jerrypainter
Copy link

+1 hope this fix the auto layout issue in child view controllers

@rodericj
Copy link
Contributor

rodericj commented Jul 7, 2015

@jerrypainter, did it work for you?

@gmogames
Copy link

@ankorko I have not gone deep into this, but after your changes, setting the current page index does not work.

ViewDidLoad is called only when the pages actually load and the [setupPagingProcess] is not called and the self.scrollview is not set, so the [pageViewController setCurrentIndex:1 animated:NO]; does not work based on the examples given by the demos from @StefanLage

Might be worth checking out.

@ankorko
Copy link
Author

ankorko commented Jan 29, 2016

@gmogames this PR is one year old. To be honest I will probably not look into it, all I can remember is that View Controller containment was not done properly. Feel free to propose a change if you figure it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants