-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window not updating during resizing #71
Comments
I believe this is a Windows issue rather than a Walnut issue as this happens to a wide variety of applications using ImGui or even Qt in my experience. I also don't see it happen on Linux builds of the same applications |
This is not a Windows issue, but an issue in the default ImGui implementation. |
Oh damn, you seem to be correct, my mistake |
@TheCherno Is Walnut derived from Hazel's code or the other way around? |
@learn-more Hello, were you able to fix this? I tried updating my ImGui submodule inside Walnut to see if a newer build would help but I wasn't able to achieve it. Resizing still has this odd behaviour. If you have a PR to commit, I would be happy to give it a look to implement it on my project. |
I fixed this locally, but since this repository does not seem active at all I assumed the project to be abandoned. It needs both a fix in their fork of GLFW (to do with invalidating window contents), and some changes in the
If you really need this I can probably dig it up from my old machine, but that will take a while. From memory the patch in glfw was changing this code to return |
@learn-more Thank you for the quick reply! Also, changing the Walnut ImGui fork to my own fork of the updated ImGui repository seemed to break the custom Titlebar. Spent some hours trying to fix it with no success. I will probably try to reverse changes and apply your code on top of the original code from StudioCherno. Let's see. Thank you once again! |
Correction: Walnut was initially released in 2022, and the last update on the dev branch was from July 17th 2023 👍 |
While the window is being resized, it is not updating.
This leads to artifacts on the right and bottom of the screen.
Is there interest in a PR fixing this?
The text was updated successfully, but these errors were encountered: