Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Check if map platform exists #11

Closed
chitgoks opened this issue Jan 30, 2022 · 8 comments
Closed

Feature Request: Check if map platform exists #11

chitgoks opened this issue Jan 30, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@chitgoks
Copy link
Contributor

Rather than the code throwing an exception, how about adding an if condition check so we can customize our own actions for it.

@SupasinTatiyanupanwong
Copy link
Owner

Initially I was planned to have it changeable at runtime but that probably don't have a good use case for it and such never get materialized.

Do you have anything in your mind now? In addition to adding new API for availablity checks, I'm thinking between no-op implementation instead of crashing the app or providing a way for API hook so that the client can still make use of the map functionalities on their own. What do you think?

@chitgoks
Copy link
Contributor Author

if theres a way not to crash the app, the better. i was thinking a true/false method. if theres no map, i show a prompt and then quit the app

@SupasinTatiyanupanwong SupasinTatiyanupanwong self-assigned this Feb 8, 2022
@SupasinTatiyanupanwong SupasinTatiyanupanwong added the enhancement New feature or request label Feb 8, 2022
@chitgoks
Copy link
Contributor Author

Up. By the way, your email does not exist anymore.

@SupasinTatiyanupanwong
Copy link
Owner

Hmm, seems like I forgot to continue my domain renewal.

Thanks for letting me know! Quite busy these days.

Sorry for the delay, tho.

@chitgoks
Copy link
Contributor Author

its ok. i was worried the project might be abandoned 😅

yours is a great lib

@nettnikl
Copy link

nettnikl commented Mar 27, 2023

Hi, seconding this. The nextbike app uses this lib, and crashes on my phone, which has neither of the supported map providers. This is especially sad, as i dont need the map in this app.

So, i would prefer the no op solution, to make the app compatible with my phone.

@SupasinTatiyanupanwong
Copy link
Owner

Hi, seconding this. The nextbike app uses this lib, and crashes on my phone, which has neither of the supported map providers. This is especially sad, as i dont need the map in this app.

So, i would prefer the no op solution, to make the app compatible with my phone.

I'm working on it now, will release shortly.

@SupasinTatiyanupanwong
Copy link
Owner

The check is now available with MapKit#isMapsOperational() since 2.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants