BUG: ElastixRegistrationMethod shouldn't put "NoInitialTransform" in map #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-Dekker
commented
Jun 5, 2023
Comment on lines
226
to
234
| // An initial transform parameter file may be specified by m_InitialTransformParameterFileName, and passed via the | ||
| // argument map (specifically the "-t0" argument), but not via the registration parameter map. | ||
| if (parameterMap.count("InitialTransformParametersFileName") != 0) | ||
| { | ||
| elx::log::warn( | ||
| "The parameter map entry for \"InitialTransformParametersFileName\" is ignored. " | ||
| "`ElastixRegistrationMethod` only supports specifying an initial transform parameter file by calling " | ||
| "`SetInitialTransformParameterFileName`"); | ||
| } |
There was a problem hiding this comment.
Discussed at the sprint. No need to produce a warning here, as agreed with Marius (@mstaring). The "InitialTransformParametersFileName" is not relevant for elastix registration parameter files, just ignore it. Konstantinos (@ntatsisk) asked to check if the "NoInitialTransform" wasn't there to avoid some warning/error log messages from elastix.
ElastixRegistrationMethod should not set "NoInitialTransform" as parameter value of `InitialTransformParametersFileName`. The value "NoInitialTransform" might cause confusion, as the registration might still have an initial transform parameter file, specified by `SetInitialTransformParameterFileName`. With this commit, `ElastixRegistrationMethod` just ignores any such `InitialTransformParametersFileName` parameter, as suggested to me by Marius Staring, during the internal weekly sprint.
N-Dekker
force-pushed
the
ElastixRegistrationMethod-ignore-InitialTransformParametersFileName
branch
from
e82e366
to
aa1320c
Compare
N-Dekker
deleted the
ElastixRegistrationMethod-ignore-InitialTransformParametersFileName
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElastixRegistrationMethod should not set "NoInitialTransform" as parameter value of
InitialTransformParametersFileName. The value "NoInitialTransform" might cause confusion, as the registration might still have an initial transform parameter file, specified bySetInitialTransformParameterFileName.For the record, ElastixFilter (the predecessor of ElastixRegistrationMethod) started setting the value "NoInitialTransform" in the registration parameter map with pull request #50 commit 6a7f916, "ENH: Explicitly ignore InitialTransformParametersFileName set via parameter maps in ElastixFilter", merged on March 20, 2018:
elastix/Core/Main/elxElastixFilter.hxx
Lines 218 to 222 in 6a7f916
FYI @kaspermarstal