Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feedback-pipeline-3] removed structopt for parsing commandline arguments #504

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

CommanderStorm
Copy link
Member

First PR in the #501 PR-Train

⚠️ This change has been pulled out, as this is a breaking API-Chnage ⚠️

Proposed Changes (include Screenshots if possible)

  • removal of structopt to get keys from arguments as an alternative to commandline arguments

How to test this PR

  • see if this removal is okay

How has this been tested?

  • smoke + unit tests

Checklist:

  • I have updated the documentation / No need to update the documentation
  • I have run the linter

@CommanderStorm CommanderStorm added the server Related to the backend/server label Apr 10, 2023
@CommanderStorm CommanderStorm self-assigned this Apr 10, 2023
@CommanderStorm CommanderStorm changed the title removed structopt for parsing commandline arguments [feedback-pipeline-3] removed structopt for parsing commandline arguments Apr 10, 2023
Copy link
Contributor

@octycs octycs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are all fine for me. Maybe it would be good to mention GITHUB_TOKEN and JWT_KEY in the Readme now.

@CommanderStorm CommanderStorm merged commit f9a2317 into coordidante_feedback_2 Apr 10, 2023
@CommanderStorm CommanderStorm deleted the coordidante_feedback_3 branch April 10, 2023 21:22
CommanderStorm added a commit that referenced this pull request Apr 10, 2023
* changed the feedback api (renaming `delete_issue_requested` to `deletion_requested`)
* [feedback-pipeline-3] removed `structopt` for parsing commandline arguments (#504)

* removed structopt for parsing commandline arguments
* documented the used environment variables in the README
CommanderStorm added a commit that referenced this pull request Apr 12, 2023
…ructured (#502)

* refactored the feedback system to be flatter structured

* [feedback-pipeline-2]  API Change (#503)

* changed the feedback api (renaming `delete_issue_requested` to `deletion_requested`)
* [feedback-pipeline-3] removed `structopt` for parsing commandline arguments (#504)

* removed structopt for parsing commandline arguments
* documented the used environment variables in the README

* refactored token management to be fully based in the tokens module

* formatting fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Related to the backend/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants