fix(devtools): make sure that sort function is properly read from localStorage

[zorzysty]

Fix for: #3639: DevTools doesn't remember the sort function

This effect is causing the problem. Good news is that it's also completely unneeded as it's doubling what's already done via useLocalStorage. And if the runs after (which it usually does), it disregards the value that's read by useLocalStorage hook - which is exactly what causes the bug.

This is easily fixable by simply removing the effect.

[codecov-commenter]

Codecov Report

Merging #3703 (f50c04c) into beta (e0aad73) will decrease coverage by 0.30%.
The diff coverage is 93.29%.

@@            Coverage Diff             @@
##             beta    #3703      +/-   ##
==========================================
- Coverage   97.11%   96.81%   -0.31%     
==========================================
  Files          50       57       +7     
  Lines        2391     2668     +277     
  Branches      706      784      +78     
==========================================
+ Hits         2322     2583     +261     
- Misses         67       83      +16     
  Partials        2        2              

Impacted Files	Coverage Δ
packages/query-core/src/infiniteQueryObserver.ts	100.00% <ø> (ø)
packages/query-core/src/logger.ts	100.00% <ø> (ø)
packages/react-query-devtools/src/Logo.tsx	100.00% <ø> (ø)
...kages/react-query-devtools/src/styledComponents.ts	92.30% <ø> (ø)
packages/react-query-devtools/src/theme.tsx	100.00% <ø> (ø)
packages/react-query-devtools/src/useMediaQuery.ts	92.30% <ø> (ø)
...-persist-client/src/PersistQueryClientProvider.tsx	100.00% <ø> (ø)
packages/react-query-persist-client/src/persist.ts	92.85% <ø> (ø)
...ages/react-query/codemods/v4/key-transformation.js	97.36% <ø> (ø)
packages/react-query/codemods/v4/utils/index.js	98.50% <ø> (ø)
... and 67 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25e964...f50c04c. Read the comment docs.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f50c04c:

Sandbox	Source
@tanstack/query-example-react-basic	Configuration
@tanstack/query-example-react-basic-typescript	Configuration

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
query	✅ Ready (Inspect)	Visit Preview	Jul 17, 2022 at 1:11PM (UTC)