Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add error message for skipToken in useSuspenseQueries and useSuspenseInfiniteQuery #7797

Merged

Conversation

hautest
Copy link
Contributor

@hautest hautest commented Jul 26, 2024

#7768

Add detailed error messages in non-production environments when using skipToken in the queryFn of useSuspenseQueries and useSuspenseInfiniteQuery.

Before

350684110-c03338cb-01c2-416f-a2c8-879631217fbd

After

350684038-416881d7-e46c-49de-b2cb-9f76b61b2798

Copy link

nx-cloud bot commented Jul 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 535f8c0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Jul 26, 2024

commit: 535f8c0

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7797
pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@7797
pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@7797
pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@7797
pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7797
pnpm add https://pkg.pr.new/@tanstack/query-core@7797
pnpm add https://pkg.pr.new/@tanstack/query-devtools@7797
pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@7797
pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@7797
pnpm add https://pkg.pr.new/@tanstack/react-query@7797
pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@7797
pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@7797
pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@7797
pnpm add https://pkg.pr.new/@tanstack/solid-query@7797
pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@7797
pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@7797
pnpm add https://pkg.pr.new/@tanstack/svelte-query@7797
pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@7797
pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@7797
pnpm add https://pkg.pr.new/@tanstack/vue-query@7797
pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@7797

Open in Stackblitz

More templates

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.80%. Comparing base (bd3296b) to head (535f8c0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #7797       +/-   ##
===========================================
+ Coverage   44.58%   85.80%   +41.21%     
===========================================
  Files         185       24      -161     
  Lines        7078      324     -6754     
  Branches     1566       83     -1483     
===========================================
- Hits         3156      278     -2878     
+ Misses       3559       39     -3520     
+ Partials      363        7      -356     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query 92.44% <75.00%> (-0.55%) ⬇️
@tanstack/react-query-devtools 10.71% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit 34a5672 into TanStack:main Jul 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants