Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#189 bestpiickle #194

Merged
merged 3 commits into from
Feb 5, 2023
Merged

Feat/#189 bestpiickle #194

merged 3 commits into from
Feb 5, 2023

Conversation

NYeonK
Copy link
Contributor

@NYeonK NYeonK commented Feb 1, 2023 •
edited
Loading

  • 브랜치명, 브랜치 알맞게 설정
  • Reviewer, Assignees, Label, Milestone, Issue(PR 작성 후에) 붙이기
  • PR이 승인된 경우 해당 브랜치는 삭제하기

📌 내용

  • Best Piickle 카드 보기 버튼의 width 값을 수정합니다.
  • Best Piickle Slider 왼쪽 마진 값을 수정합니다.
  • 이번에 수정하고 나서도 다시 한 번 더 팀원들의 캡쳐본이 필요할 것 같네유😅💦
  • 원래 잘 뜨던 사용자들을 고려해서, 카드가 짤리지 않고 다 보이는 것을 기준으로 찔끔! 옮겼습니다.
    (갤럭시 노트8, 아이패드 에어4로 확인)

📸 스크린샷

  • 아이패드 에어4 dev 화면

  • 아이패드 에어4 수정 화면

@NYeonK NYeonK self-assigned this Feb 1, 2023
@NYeonK NYeonK linked an issue Feb 1, 2023 that may be closed by this pull request
[ common ] QA 반영 #189
Closed
16 tasks
@NYeonK NYeonK mentioned this pull request Feb 1, 2023
Closed
16 tasks
@NYeonK NYeonK changed the base branch from develop to release/1.2 February 4, 2023 18:22
@NYeonK NYeonK marked this pull request as ready for review February 4, 2023 18:38
@NYeonK NYeonK requested a review from joohaem February 4, 2023 18:38
joohaem
joohaem approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@joohaem joohaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

border까지 생각해야 되는구나...몰랐어

코드 좀만 수정하고 머지할게요 !

  • 아래 선까지 가려지게,
  • right 불필요할 것 같아서

@joohaem joohaem merged commit e6407d7 into release/1.2 Feb 5, 2023
@joohaem joohaem deleted the feat/#189-bestpiickle branch February 5, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joohaem joohaem joohaem approved these changes

Assignees

@NYeonK NYeonK

Labels
Fix 나연
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ common ] QA 반영
2 participants
@NYeonK @joohaem