Feat/#210 card collection filter UI #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 23, 2023
NYeonK
reviewed
Feb 23, 2023
| background: ${(props: RangeTrackProps) => | ||
| getTrackBackground({ | ||
| values: props.price, | ||
| colors: ["#19BE7E", "#ffffff"], // [newColors.green, newColors.white] |
Comment on lines
3
to
15
| const WhiteRoot = styled.div` | ||
| height: 100vh; | ||
|
|
||
| position: absolute; | ||
| left: 0; | ||
| right: 0; | ||
| top: 0; | ||
| z-index: 10; | ||
|
|
||
| background-color: rgb(0, 0, 0, 0.5); | ||
| display: flex; | ||
| align-items: center; | ||
| `; |
There was a problem hiding this comment.
const 부모객체 = styled.div`
중복 프로퍼티...
`;
// export
const 자식객체1 = styled(부모객체)`
추가 프로퍼티...
`;
// export
const 자식객체2 = styled(부모객체)`
추가 프로퍼티...
`;
theme이 white일 때와 default일 때의 차이가 거의 없는데, 오빠가 저번에 알려줬던거 적용하면 어떨까요?!
There was a problem hiding this comment.
맞아요 !!!!!! 👍🏼👍🏼👍🏼👍🏼
고민해봤는데, 모달 스타일링이 테마마다 언제 어떻게 바뀔지 몰라서, 상속의 개념이 아니라고 생각했어요!
Root 에만 적용하는 게 좋을 것 같아요 !!! 좋은ㅇ의견 감사합니다🥰🥰
| @@ -1,7 +1,7 @@ | |||
| import styled from "styled-components"; | |||
|
|
|||
| const ModalContentsWrapper = styled.div` | |||
| padding-top: 1.6rem; | |||
| padding: 1.6rem 1.6rem 0; | |||
There was a problem hiding this comment.
우왕 이렇게 3개 쓰면 어느 부분들이 적용되나요?!
There was a problem hiding this comment.
padding css 검색해서 찾아보셔요 !
https://developer.mozilla.org/ko/docs/Web/CSS/padding
Comment on lines
+32
to
+52
|
|
||
| ${(ariaProps) => | ||
| ariaProps["aria-valuenow"] === ariaProps["aria-valuemin"] && | ||
| css` | ||
| left: 1rem; | ||
| `} | ||
| ${(ariaProps) => | ||
| ariaProps["aria-valuenow"] === 1 && | ||
| css` | ||
| left: 0.7rem; | ||
| `} | ||
| ${(ariaProps) => | ||
| ariaProps["aria-valuenow"] === 2 && | ||
| css` | ||
| left: -0.7rem; | ||
| `} | ||
| ${(ariaProps) => | ||
| ariaProps["aria-valuenow"] === ariaProps["aria-valuemax"] && | ||
| css` | ||
| left: -1rem; | ||
| `} |
leeJooHaem
force-pushed
the
feat/#210-card_collection_filter_ui
branch
from
a16b064
to
a6cb47f
Compare
NYeonK
reviewed
Feb 24, 2023
Comment on lines
+8
to
+12
| theme: DefaultTheme & { | ||
| newColors: { | ||
| [key: string]: string; | ||
| }; | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
4시간소요📌 질문할 부분
react-range라이브러리에 의존한 형태라서 UI 바꾸기가 굉장히 까다롭네요😂😂 결국 확장성 부족한 코드로 갈겨놨어요 (https://w1655692613-dsw141740.slack.com/archives/C04FGQCL894/p1677139628365579?thread_ts=1677068521.636239&cid=C04FGQCL894)📸 스크린샷