Hotfix/#218 메들리 기능 이슈 해결 #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
7 tasks
7 tasks
NYeonK
reviewed
Mar 17, 2023
| @@ -7,9 +8,10 @@ import { PiickleSWRResponse } from "../../../types/remote/swr"; | |||
|
|
|||
| export function useMedleyLists() { | |||
| const { data, error } = useSWR<PiickleSWRResponse<MedleyCard[]>>(`${PATH.MEDLEY}`, realReq.GET_SWR); | |||
| const randomMedleyLists = useMemo(() => data?.data.data.sort(() => Math.random() - 0.5), [data]); | |||
There was a problem hiding this comment.
궁금한게 있어요😵 이 코드는 data가 변할 때마다, 랜덤함수를 반환하라는 거죠?!
새로고침할 때랑, 카드뷰 들어갔다 나오면 메들리 순서가 변경되는데
data는 구롬 언제 바뀌는지에 대한 코드가 어디있는지 아시나용?-?
There was a problem hiding this comment.
@NYeonK
swr에서 언제 데이터가 revalidate 되는지 살펴보면 될 것 같아요!
살펴보고 저도 알려주세요 !!
|
시간복잡도도 생각하는 그,, 증맬루 멋있다,,⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
mouseDown할 때부터 화면이 계속 업데이트 됨으로써, 커스텀 훅이 random 함수 계속해서 새롭게 반환시켜줘요. 그래서 클릭 이벤트가 일어나지 않아 프리뷰를 볼 수가 없었어요. 이를useMemo로 계속해서 변하지 않게끔 막아주었습니다O(n)) 객체에서 index를 찾아 반환(O(1))하는 방식이 효율적일 것 같아 수정하였습니다.