Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/#233 filter modal #244

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Bug/#233 filter modal #244

merged 2 commits into from
Mar 24, 2023

Conversation

NYeonK
Copy link
Contributor

@NYeonK NYeonK commented Mar 24, 2023

  • 브랜치명, 브랜치 알맞게 설정
  • Reviewer, Assignees, Label, Milestone, Issue(PR 작성 후에) 붙이기
  • PR이 승인된 경우 해당 브랜치는 삭제하기

📌 내용

  • 필터 모달 QA를 진행했습니다. ( 모달 버튼 width 값 추가, 모달 opacity 클릭 시, 닫기 가눙)

📸 스크린샷

@NYeonK NYeonK self-assigned this Mar 24, 2023
@NYeonK NYeonK linked an issue Mar 24, 2023 that may be closed by this pull request
[ Common ] QA 반영 #233
Closed
6 tasks
@NYeonK NYeonK requested a review from joohaem March 24, 2023 14:50
joohaem
joohaem approved these changes Mar 24, 2023
View reviewed changes
Copy link
Member

@joohaem joohaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥🔥

@NYeonK NYeonK merged commit ffea25b into release/1.3 Mar 24, 2023
@NYeonK NYeonK deleted the bug/#233-filter_modal branch March 24, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joohaem joohaem joohaem approved these changes

Assignees

@NYeonK NYeonK

Labels
Feature Fix 나연
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ Common ] QA 반영
2 participants
@NYeonK @joohaem