Hotfix/mobile join #253
Merged
Hotfix/mobile join #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joohaem
reviewed
Apr 1, 2023
There was a problem hiding this comment.
- 바깥 쪽을 클릭해도 되는 useOutClickCLoser를 따로 선언해서 부착하면 될 것 같아요. (혹은 props로 이 조건의 유무를 추가한다거나)
- 현재 브랜치들의 반영정도가 다른데,
main/develop/release/1.3의 커밋을 align 해주세요! (이제 release/1.3은 사용하지 않아도 될 것 같습니다! develop으로 이용하면 될 것 같아요) - 해당 PR은 dev 브랜치로 머지가 되었는데, hotfix는 main 브랜치에 바로 반영하는 브랜치입니다!!!
|
원인 파악해서 빠르게 대응해주셔서 감사합니다😊☺🙏🏼🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
📌 내가 알게 된 부분
useOutClickCloser()가 메뉴바나 메들리 프리뷰 띄울 때, 오퍼시티 부분의 이벤트들을 막는데요~이게 이용동의 필수 약관 미선택 시, 생기는 토스트메세지에 적용이 되어 있어서, 회원가입 버튼이 안눌리던거였습니다,,,🤯🤯
-> 근데 하필
preventDefault()요 메소드때문에 작동을 안하는거라, 임시방편으로 토스트메세지 부분의useOutClickCloser()를 주석처리해두었습니다!스크롤이 안되는 문제는
useOutClickCloser()와 다른 이유인 것 같습니다,,,,,,🤢 그래서useScroll()로 페이지 맨 상단으로 이동하게 만들어두었어요