#277 업데이트 알림 뷰 #281
Merged
#277 업데이트 알림 뷰 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
joohaem
commented
May 2, 2023
| import Medley from "./Medley"; | ||
| import MoodPiickle from "./MoodPiickle"; | ||
| import PiickleMe from "./PiickleMe"; | ||
| import StripBanner from "./StripBanner"; | ||
| import { St } from "./style"; | ||
| import UpdateModal from "./UpdateModal"; | ||
|
|
||
| const UpdateModal = lazy(() => import("./UpdateModal")); |
There was a problem hiding this comment.
전체 UI가 나온 이후에, 업데이트 모달창을 띄우고 싶었습니다.!
| closeHandler: () => void; | ||
| } | ||
| export default function UpdateModal() { | ||
| const { isOpened, handleCloseModal } = useUpdateModal(); |
There was a problem hiding this comment.
오왓 이런 방법이,,!
if (!isOpened) return null; 짱짱+-+!!!!!
NYeonK
approved these changes
May 2, 2023
| } | ||
|
|
||
| export default function Modal(props: PropsWithChildren<ModalContents>) { | ||
| const { theme = "DEFAULT", closeHandler, closeOpacityClassName, closeBtnClassName, children } = props; | ||
| const { theme = "DEFAULT", closeHandler, closeOpacityClassName, closeBtnClassName, isNoCloseBtn, children } = props; |
| closeHandler: () => void; | ||
| } | ||
| export default function UpdateModal() { | ||
| const { isOpened, handleCloseModal } = useUpdateModal(); |
There was a problem hiding this comment.
오왓 이런 방법이,,!
if (!isOpened) return null; 짱짱+-+!!!!!
| id: number; | ||
| content: string; | ||
| }; | ||
|
|
||
| export const versionUpdateList: VersionUpdateList[] = [ | ||
| export const VERSION_UPDATES: VersionUpdate[] = [ |
There was a problem hiding this comment.
이렇게 하눈거구나~ 이거 넘나 헷갈리는고!-!
util 폴더의 비슷한 다른 파일들 참고했는데, Upper Case로 바꾸면 좋을 것들이 많을 것 같네용:)
변수명을 다 바꿨길래 궁금한건데용 파일명은 일부러 안바꾸신거겠죠?
There was a problem hiding this comment.
@NYeonK 생각 못했어요 하하하 바꾸셔도 좋습니다 !!!!!!!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용