Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card Memoization #289

Merged
merged 2 commits into from
May 29, 2023
Merged

Card Memoization #289

merged 2 commits into from
May 29, 2023

Conversation

joohaem
Copy link
Member

@joohaem joohaem commented May 27, 2023

  • 브랜치명, 브랜치 알맞게 설정
  • Reviewer, Assignees, Label, Milestone, Issue(PR 작성 후에) 붙이기
  • PR이 승인된 경우 해당 브랜치는 삭제하기

📌 내용

  • 카드 슬라이더에서의 render phase 렌더링을 막아 성능 최적화를 진행해요.
  • Card 컴포넌트에는 메모이제이션이 되어있지만 LastCard 에는 되어있지 않았어요.
  • 3번 스와이핑 기준, 2배 가까이 렌더링 시간을 단축해요.

📸 스크린샷

Before

image

After

image

@joohaem joohaem requested a review from NYeonK May 27, 2023 09:45
@joohaem joohaem self-assigned this May 27, 2023
Copy link
Contributor

@NYeonK NYeonK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세심한 사람👍🌟💡😎

렌더링 시간 확인하는게 신기하네용👀👀

@@ -10,6 +10,7 @@

# production
/build
/dist
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

production일 때, dist 파일이 생기나요!?!?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로컬 환경에서 빌드를 하면 vite이기 때문에 dist 폴더 내에 빌드된 파일들이 저장돼요! (기존에는 build 파일)
직접 빌드해보고 하면서 그냥 숨겨놔야겠다 생각해서 추가해놓았습니다

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오옹 궁금해서 방금 해봤는데 그렇네요~!! 짱짱🌟🌟

@joohaem joohaem merged commit efd189e into develop May 29, 2023
@joohaem joohaem deleted the feat/memo_card branch May 29, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants