Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/#25 axios #29

Merged
merged 4 commits into from
Jul 14, 2022
Merged

Feat/#25 axios #29

merged 4 commits into from
Jul 14, 2022

Conversation

henization
Copy link
Contributor

@henization henization commented Jul 12, 2022

  • 브랜치명, 브랜치 알맞게 설정
  • Reviewer, Assignees, Label, Milestone, Issue(PR 작성 후에) 붙이기
  • PR이 승인된 경우 해당 브랜치는 삭제하기

📌 내용

  • 1시간반~2시간
  • API 통신객체를 생성했다

📌 내가 알게 된 부분

  • API 통신객체를 어떻게 만드는지 알게됐고 두려움이 사라지댜댜ㅑ~

📌 질문할 부분

  • 여러 타입이 들어오는 body에 어떤 타입을 주면 좋을까요? 유틸리티 써야하나?

📸 스크린샷

@henization henization self-assigned this Jul 12, 2022
@henization henization added this to the 🔥 Demo Day 🔥 milestone Jul 12, 2022
@henization henization linked an issue Jul 12, 2022 that may be closed by this pull request
3 tasks
Copy link
Member

@joohaem joohaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와아 고생했어요 !!!

서버 통신하면서 안 맞는 부분 수정해가면서 하면 되니까 !!
틀을 잘 마련해줘서 고마워요 !!!~

Copy link
Contributor

@NaveOWO NaveOWO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헨 너무 고생했다🙈🙈 아직 안써봐서 모르겠는데 이렇게 보니깐 API들 대략적으로 알 것 같아욤!!!

Comment on lines +24 to +30
async PATCH(path: string, body) {
await real.patch(path, body);
},

async DELETE(path: string, body) {
await real.delete(path, body);
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patch 랑 delete 에는 왜 return이 없는 걸까요!?

@joohaem joohaem merged commit 3561ebb into develop Jul 14, 2022
@joohaem joohaem deleted the feat/#25-axios branch July 14, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Common ] axios file setting
3 participants