[ Login ] 로그인 뷰 구현 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
henization
reviewed
Jul 14, 2022
| @@ -1,5 +1,9 @@ | |||
| import { St } from "./style"; | |||
|
|
|||
| export default function CTABtn() { | |||
| return <St.Button to="/category">대화주제 추천 바로가기</St.Button>; | |||
| return ( | |||
| <St.Button role="button" to="/category"> | |||
There was a problem hiding this comment.
button 태그가 아니라 Link 태그의 요소이고, 스크린리더에서 읽히는 role 을 명시하기 위해 추가하였습니다!
src/components/Main/MenuBar/style.ts
Outdated
Comment on lines
7
to
9
| /* width: 36rem; | ||
| height: 100vh; */ | ||
|
|
Comment on lines
15
to
25
| // return ( | ||
| // <St.HeaderWrapper> | ||
| // <Link to="/"> | ||
| // <IcLogo aria-label="피클" /> | ||
| // </Link> | ||
| // <St.HamburgerContainer isClicked={isOpened}> | ||
| // <IcHamburger aria-label="메뉴" onClick={handleModal} /> | ||
| // </St.HamburgerContainer> | ||
| // </St.HeaderWrapper> | ||
| // ); | ||
|
|
| // ); | ||
|
|
||
| useEffect(() => { | ||
| console.log(isOpened); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
errorMessagestate 로 통해 이메일, 비밀번호 다를 때에 메시지를 나타냅니다📌 내가 알게 된 부분
--> UX 적으로 디자인팀에서 합의한 내용
📸 스크린샷