Feat/#47 login modal #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
NaveOWO
reviewed
Jul 16, 2022
|
|
||
| return ( | ||
| <St.Card> | ||
| <St.TagsWrapper> | ||
| <TagsSlider tags={["재미", "if충", "if충", "if충", "if충", "if충", "if충", "if충", "if충x"]} /> | ||
| </St.TagsWrapper> | ||
| <St.ContentWrapper>우리집공양추르하ㅐ</St.ContentWrapper> | ||
| <St.HeartWrapper onClick={() => setIsBookmarked((prev) => !prev)}> | ||
| <St.HeartWrapper onClick={clickHandle}> |
| <Card /> | ||
| <Card /> | ||
| <Card /> | ||
| <Card LoginopenHandler={openLoginModalHandler} /> |
There was a problem hiding this comment.
헷갈리니깐 이름 순서는 통일해줘도 좋지 않을까욧?!
There was a problem hiding this comment.
아하, filter랑 login 순서 말하는 걸까요??
There was a problem hiding this comment.
openLoginModalHandler={openLoginModalHandler} 로 통일 말하는 고 같은데??~
| import { St } from "./style"; | ||
|
|
||
| export default function CardCollection() { | ||
| const [isOpened, setIsOpened] = useState<boolean>(false); | ||
| const [isLoginOpened, setLoginOpened] = useState<boolean>(false); |
There was a problem hiding this comment.
useState 초깃값을 지정해줄때는 타입을 지정 안해줘도 알아서 판단한대욤! 근데 이때 써주는게 더 좋은지 안써주는게 더 좋은지는 까먹었다! 도와줘 주함&헨
henization
reviewed
Jul 16, 2022
|
|
||
| return ( | ||
| <St.Card> | ||
| <St.TagsWrapper> | ||
| <TagsSlider tags={["재미", "if충", "if충", "if충", "if충", "if충", "if충", "if충", "if충x"]} /> | ||
| </St.TagsWrapper> | ||
| <St.ContentWrapper>우리집공양추르하ㅐ</St.ContentWrapper> | ||
| <St.HeartWrapper onClick={() => setIsBookmarked((prev) => !prev)}> | ||
| <St.HeartWrapper onClick={clickHandle}> |
| </St.Wrapper> | ||
| <St.Buttons> | ||
| <St.LoginButton to="/login">로그인</St.LoginButton> | ||
| <St.SignUpButton>회원가입</St.SignUpButton> |
There was a problem hiding this comment.
button 태그가 아닌 Link 태그로 대체될 것 같습니당
| import { St } from "./style"; | ||
|
|
||
| export default function CardCollection() { | ||
| const [isOpened, setIsOpened] = useState<boolean>(false); | ||
| const [isLoginOpened, setLoginOpened] = useState<boolean>(false); |
Comment on lines
20
to
30
| const openLoginModal = () => { | ||
| setLoginOpened(true); | ||
| }; | ||
| const closeLoginModal = () => { | ||
| setLoginOpened(false); | ||
| }; | ||
|
|
||
| const clickHandleFilterModal = () => { | ||
| openModal(); | ||
| }; | ||
|
|
joohaem
approved these changes
Jul 16, 2022
| const [isBookmarked, setIsBookmarked] = useState(false); | ||
| const { LoginopenHandler } = props; | ||
| const clickHandle = () => { |
There was a problem hiding this comment.
handleClickHeart 정도로 좀 더 서술함이 어떨까 합니다!
| <Card /> | ||
| <Card /> | ||
| <Card /> | ||
| <Card LoginopenHandler={openLoginModalHandler} /> |
There was a problem hiding this comment.
openLoginModalHandler={openLoginModalHandler} 로 통일 말하는 고 같은데??~
| </St.Wrapper> | ||
| <St.Buttons> | ||
| <St.LoginButton to="/login">로그인</St.LoginButton> | ||
| <St.SignUpButton>회원가입</St.SignUpButton> |
There was a problem hiding this comment.
button 태그가 아닌 Link 태그로 대체될 것 같습니당
|
빠른 코드리뷰 반영 ~~~~~~~~~~~~~~~~~~ 고맙습니다> < |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
📌 내가 알게 된 부분
<modal>을 가져다 쓰는 법을 알게 되었습니당~!!📌 질문할 부분
📸 스크린샷