Feat/#78 nayeon qa #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
joohaem
requested changes
Jul 19, 2022
src/components/Main/Banner/style.ts
Outdated
Comment on lines
31
to
33
| letter-spacing: -0.03em; | ||
| ${({ theme }) => theme.fonts.caption4}; | ||
| color: ${({ theme }) => theme.colors.white}; |
There was a problem hiding this comment.
letter-spacing 은 theme 에 있는 속성인데 이 글자만 달랐던 걸까요??
There was a problem hiding this comment.
-0.04 로 설정되어 있어서 그렇구나- 제가 수정할게요!
Comment on lines
45
to
48
|
|
||
| letter-spacing: -0.03em; | ||
| ${({ theme }) => theme.fonts.body3}; | ||
| color: ${({ theme }) => theme.colors.gray800}; |
There was a problem hiding this comment.
letter-spacing 은 theme 에 있는 속성인데 이 글자만 달랐던 걸까요??
NaveOWO
reviewed
Jul 19, 2022
Comment on lines
-27
to
-30
| // const location = useLocation(); | ||
| // const CARD_TYPE = location.state as number...?; | ||
| // eslint-disable-next-line prefer-const | ||
| let CARD_TYPE_LOCATION: CardsTypeLocation = { type: "category", categoryId: "62cbb7d8a8c54f168a6ddfe1" }; |
There was a problem hiding this comment.
안쓰는 변수 지워주세요~~~(이주함 따라한거임)
| @@ -8,7 +8,7 @@ export const St = { | |||
| Form: styled.form``, | |||
|
|
|||
| Title: styled.h2` | |||
| margin-bottom: 2rem; | |||
| padding: 2.4rem 0; | |||
There was a problem hiding this comment.
요게 채민이가 말한 제목 사이 패딩값이애오!??! Header에 일정하게 margin 주고 페이지마다 일일히 -margin 값 주려고 했는데 요게 맞나....1?!?!?!?!
There was a problem hiding this comment.
엇 언니가 하려던대로 하려면 수정해야 합니당!!
henization
reviewed
Jul 19, 2022
|
|
||
| letter-spacing: -0.03rem; | ||
| ${({ theme }) => theme.fonts.body4}; | ||
| ${({ theme }) => theme.fonts.body6}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 내용
📌 내가 알게 된 부분
📌 질문할 부분
📸 스크린샷
밑의 사진은 그냥 넣어봤어요~~
