Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#78 jiyeong qa #84

Merged
merged 9 commits into from
Jul 19, 2022
Merged

Feat/#78 jiyeong qa #84

merged 9 commits into from
Jul 19, 2022

Conversation

NaveOWO
Copy link
Contributor

@NaveOWO NaveOWO commented Jul 19, 2022

  • 브랜치명, 브랜치 알맞게 설정
  • Reviewer, Assignees, Label, Milestone, Issue(PR 작성 후에) 붙이기
  • PR이 승인된 경우 해당 브랜치는 삭제하기

📌 내용

  • 디자인 QA 투표부분 수정했습니다!

📌 내가 알게 된 부분

  • 디자인 QA는 어렵다............................

📌 질문할 부분

  • 우리.... 앱잼 끝나면 헤어지는거애오..........??

📸 스크린샷

@NaveOWO NaveOWO self-assigned this Jul 19, 2022
@NaveOWO NaveOWO linked an issue Jul 19, 2022 that may be closed by this pull request
[ Common ] Jiyeong Design QA #79
Closed
7 tasks
joohaem
joohaem approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@joohaem joohaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석

src/components/Vote/VoteContent/style.ts Outdated Show resolved Hide resolved
src/components/Vote/VoteContent/style.ts Outdated Show resolved Hide resolved
src/components/Vote/VoteTitle/style.ts Outdated Show resolved Hide resolved
@joohaem joohaem merged commit d1f879a into develop Jul 19, 2022
@joohaem joohaem deleted the feat/#78-JiyeongQA branch July 19, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joohaem joohaem joohaem approved these changes

@NYeonK NYeonK Awaiting requested review from NYeonK

@henization henization Awaiting requested review from henization

Assignees

@NaveOWO NaveOWO

Labels
Feature Fix Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ Common ] Jiyeong Design QA
2 participants
@NaveOWO @joohaem