Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate SDK using a generator #2

Merged
merged 40 commits into from
Apr 25, 2024
Merged

Generate SDK using a generator #2

merged 40 commits into from
Apr 25, 2024

Conversation

Aditya-Kumar-Code
Copy link
Contributor

Will Close #1

sutyum
sutyum requested changes Apr 23, 2024
View reviewed changes
.DS_Store Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
sutyum
sutyum requested changes Apr 23, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
sutyum
sutyum requested changes Apr 23, 2024
View reviewed changes
openapi_client/__init__.py Outdated Show resolved Hide resolved
sutyum
sutyum requested changes Apr 24, 2024
View reviewed changes
examples/consent_change_notification.py Outdated Show resolved Hide resolved
abdm-hiu-sdk/__init__.py Outdated Show resolved Hide resolved
sutyum
sutyum requested changes Apr 25, 2024
View reviewed changes
.github/workflows/abdm.yml Outdated Show resolved Hide resolved
@sutyum
Copy link
Member

sutyum commented Apr 25, 2024

Pass the tests in order to merge

sutyum
sutyum requested changes Apr 25, 2024
View reviewed changes
examples/consent_change_notification.py Show resolved Hide resolved
hiu_api.py Outdated Show resolved Hide resolved
sutyum
sutyum requested changes Apr 25, 2024
View reviewed changes
LICENSE Show resolved Hide resolved
sutyum
sutyum requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@sutyum sutyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gitignored files have been committed and gitignore file deleted, etc

.DS_Store Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
sutyum
sutyum requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@sutyum sutyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all the pycache dirs need to be deleted, along with .DS_Store

@sutyum
Copy link
Member

sutyum commented Apr 25, 2024

your workflow is currently running type checking on the test dir as well. You can skip typechecking in the test dir

sutyum
sutyum requested changes Apr 25, 2024
View reviewed changes
LICENSE Show resolved Hide resolved
sutyum
sutyum requested changes Apr 25, 2024
View reviewed changes
Copy link
Member

@sutyum sutyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned earlier, all the pycache folders need to be deleted

sutyum
sutyum requested changes Apr 25, 2024
View reviewed changes
.github/workflows/abdm.yml Outdated Show resolved Hide resolved
sutyum
sutyum requested changes Apr 25, 2024
View reviewed changes
LICENSE Show resolved Hide resolved
@sutyum sutyum merged commit 78987e0 into dev Apr 25, 2024
2 checks passed
@sutyum sutyum deleted the ABDM-HIU-SDK branch April 25, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutyum sutyum sutyum requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate SDK using a generator
2 participants
@Aditya-Kumar-Code @sutyum