Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support lossless online/offline #1377

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

fuyuwei01
Copy link
Contributor

PR Type

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2023.
  • Will pull request to branch of 2022.
  • Will pull request to branch of 2021.
  • Will pull request to branch of 2020.
  • Will pull request to branch of hoxton.

SkyeBeFreeman and others added 2 commits August 13, 2024 15:44
Co-authored-by: andrew shan <45474304+andrewshan@users.noreply.github.com>
@SkyeBeFreeman SkyeBeFreeman added this to the 2.0.0.0 milestone Aug 13, 2024
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 89.31298% with 14 lines in your changes missing coverage. Please review.

Project coverage is 77.23%. Comparing base (54d04d8) to head (5aa4759).

Files Patch % Lines
...pter/transformer/NacosRegistrationTransformer.java 12.50% 7 Missing ⚠️
.../cloud/plugin/lossless/LosslessRegistryAspect.java 81.81% 4 Missing ⚠️
...n/java/com/tencent/cloud/common/util/UrlUtils.java 86.66% 1 Missing and 1 partial ⚠️
...cloud/polaris/registry/PolarisServiceRegistry.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2020    #1377      +/-   ##
==========================================
+ Coverage   76.86%   77.23%   +0.36%     
==========================================
  Files         256      267      +11     
  Lines        5715     5837     +122     
  Branches      699      702       +3     
==========================================
+ Hits         4393     4508     +115     
- Misses        936      946      +10     
+ Partials      386      383       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkyeBeFreeman SkyeBeFreeman merged commit f5bb38c into Tencent:2020 Aug 13, 2024
9 checks passed
@fuyuwei01 fuyuwei01 deleted the 2020-lossless branch August 15, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants