Fix #578 Update reference directory for server #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move it to the server folder instead of the kit root. This allows moving out server from a kit and use that as the set of files to copy on different hosts.
ramsai1729
reviewed
May 30, 2017
| // XXX hack to have enterprise system tests to find license key under <ee-branch>/code/base | ||
| String baseDir = System.getProperty("tc.base-dir"); | ||
| return new File(baseDir != null ? baseDir : ".", "../../../code/base"); | ||
| return new File(System.getProperty("user.dir")); |
There was a problem hiding this comment.
I don't think we are using this property TC_INSTALL_ROOT_IGNORE_CHECKS_PROPERTY_NAME, its better to remove it altogether instead of patching it.
There was a problem hiding this comment.
It is still configured in build-parent/pom.xml and I did not want to start a big clean up here, just a minor removal. Filed #582 for this bigger clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move it to the server folder instead of the kit root. This allows
moving out server from a kit and use that as the set of files to copy
on different hosts.