Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate an alternative for express-brute #161

Open
na9da opened this issue May 3, 2024 · 3 comments
Open

Investigate an alternative for express-brute #161

na9da opened this issue May 3, 2024 · 3 comments

Comments

@na9da
Copy link
Contributor

na9da commented May 3, 2024

express-brute is now 8 years old, the version of its underscore dependency has a critical security warning. For now, we have put in place yarn resolution rules to force a safer version. However we could look for an alternative solution, some options include:

One thing to consider is some of the server config params share the same names as express-brute options. If we have to avoid a breaking change, then we have to manage that somehow.

@pjonsson
Copy link
Contributor

pjonsson commented May 3, 2024

I don't know anything about these libraries, but there is also a security issue with express-brute itself.
I have no idea if node-rate-limiter-flexible fits the requirements of this project, but there is a guide for how to upgrade to it from express-brute: https://github.com/animir/node-rate-limiter-flexible/wiki/ExpressBrute-migration

@na9da
Copy link
Contributor Author

na9da commented May 3, 2024

That looks like a good alternative, thanks for the find.

@pjonsson
Copy link
Contributor

pjonsson commented May 5, 2024

I made a prototype migration in #162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants