Replace express-brute #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests pass, but I have no idea if the changed code path is exercised by the test suite. |
pjonsson
force-pushed
the
node-rate-limiter
branch
from
f03e2d4
to
d17da5b
Compare
|
@na9da this is one of the two PRs that together fixes all known security issues in terriajs-server, can you please take a look at this? |
This replaces express-brute with rate-limiter-flexible, which removes the dependency on the vulnerable underscore version, and does not have a rate limit bypass vulnerability.
pjonsson
force-pushed
the
node-rate-limiter
branch
from
70bdd86
to
33093f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces express-brute with
rate-limiter-flexible, which
removes the dependency on the vulnerable
underscore version, and does not have
a rate limit bypass vulnerability.