feat: shows attributes description on hover #15
Conversation
| @@ -60,6 +81,30 @@ fn handle_didChange(noti: Notification) -> Option<HtmxResult> { | |||
| return None; | |||
| } | |||
|
|
|||
| #[allow(non_snake_case)] | |||
| fn handle_didOpen(noti: Notification) -> Option<HtmxResult> { | |||
There was a problem hiding this comment.
Since this feature doesn't require editing the document, it needs to read the current document and store once it is opened
| @@ -83,7 +128,10 @@ fn handle_completion(req: Request) -> Option<HtmxResult> { | |||
| } | |||
| }; | |||
|
|
|||
| error!("handled result: {:?}: completion result: {:?}", completion.context, items); | |||
There was a problem hiding this comment.
I have auto-format on save 😅
|
my man! this has been huge amounts of contributions! if you wish to be invited to collaborators please let me know :) |
| @@ -26,16 +26,37 @@ struct TextDocumentChanges { | |||
| content_changes: Vec<Text>, | |||
| } | |||
|
|
|||
| #[derive(serde::Deserialize, Debug)] | |||
| struct TextDocumentOpened { | |||
There was a problem hiding this comment.
i don't know how to use the lsp-types properly yet, but we should try to get rid of these in the future (todo in a pr, don't worry)
There was a problem hiding this comment.
Do you mean implementing custom structs to parse the requests? or incomplete attributes?
lsp/src/handle.rs
Outdated
| .expect("Why it can't get HX_TAGS?") | ||
| .into_iter() | ||
| .find(|x| x.name == name)?, | ||
| _ => { |
There was a problem hiding this comment.
does this trigger if you just hover on a non attribute name / value? wont this just crash the server the moment you hover elsewhere?
There was a problem hiding this comment.
Makes sense! You mean when hovering a non-htmx attribute, I'll remove the panic
lsp/src/lib.rs
Outdated
| @@ -77,9 +78,34 @@ fn main_loop(connection: Connection, params: serde_json::Value) -> Result<()> { | |||
| error: None, | |||
| })) | |||
| } | |||
|
|
|||
| Some(HtmxResult::AttributeHover(h)) => { | |||
There was a problem hiding this comment.
at some point we may want to make this less crae crae
but for now, i am fine with this large ass function ;)
There was a problem hiding this comment.
I was under the impression you were avoiding early abstractions hehe. That's why I didn't move it to a module, but it makes sense starting to collocate some of this functionality
There was a problem hiding this comment.
Actually moving the the bit related to htmx to the htmx module makes so much sense and only have lsp related stuff in /lib.rs I moved :)
|
just answer the question abeut the _ => todo! always worry about those because it may take down our server :( |
Thanks, man! I got pretty excited to work with this kind of tooling and I wanted to brush up my Rust skills a bit 😅
I would love to! I'm not sure I can contribute as much as in the past days, but for sure I like the idea of coding some Rust from time to time in a project like this :) |
cristianoliveira
force-pushed
the
feat/describe-tags
branch
from
d80279a
to
3864e79
Compare
cristianoliveira
force-pushed
the
feat/describe-tags
branch
from
3864e79
to
747e39f
Compare
I figured there was no need to have the default for the pattern match since there were only 2 options, I wonder why rust_analyzer wasn't complaining about this 🤔 |
|
i am going to probably merge this now :) |
|
this overall looks nice, i am going to accept it :) |
Purpose
Implements the document hover feature.