[CI] Fix ci by updating lockfile & deduping action runs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pushing to a PR branch, two CI jobs are running. One for the push, and one for the pull_request. We don't want this because dups bad, but also some actions aren't happy if ran twice. Anyways, congrats for actually reading a commit message, ya legend!
MNThomson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both the
Build & Release&CIworkflows are broken:B&R: The most recent lockfile wasn't committed, whichcargogets mad at since its out of date (bad @ThePrimeagen in 78cda94)CI: It was being triggered twice, once for thepushevent and once for thepull_requestthe push was associated with. Let's dedup this (which was also causing the cargo clippy actions errors somehow)