Cleanups for clippy and text_store #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ---- - The most notable change here is the removal of unnecessary clones as suggested by clippy. Furthermore, this also makes the TextStore a wrapper type of a `HashMap<String, String>` and implements Deref and DerefMut for it. - Workflow update to ensure that clippy runs in _more_ exhaustive way (this is actually how I found about the unnecessary cloning).
|
LGTM for adding the |
armedev
reviewed
Nov 26, 2023
lsp/src/text_store.rs
Outdated
| } | ||
|
|
||
| pub fn get_text_document(uri: Url) -> Option<String> { | ||
| return TEXT_STORE | ||
| TEXT_STORE |
There was a problem hiding this comment.
yeah this isn't going to fly for me fyi
|
i'll be glad to take this pr once explicit returns are returned :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The most notable change here is the removal of unnecessary clones as suggested by clippy. Furthermore, this also makes the TextStore a wrapper type of a
HashMap<String, String>and implements Deref and DerefMut for it.Workflow update to ensure that clippy runs in more exhaustive way (this is actually how I found about the unnecessary cloning).