-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use macros to build completions statically #34
Merged
MNThomson
merged 8 commits into
ThePrimeagen:master
from
lavafroth:static-completion-structure
Dec 9, 2023
Merged
feat: use macros to build completions statically #34
MNThomson
merged 8 commits into
ThePrimeagen:master
from
lavafroth:static-completion-structure
Dec 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorry that i haven't checked this out. my fault |
could you put a little blurp about why this is a good thing? |
Without these static completions, the LSP would technically have to build the OnceCell singleton and populate it by generating the completion structs every time the LSP is run.
With these changes, the stucts themselves are built and embedded into the binary. The binary wouldn't have to cobble them together every run. Also, no more pesky .get()s like the OnceCell because the static data can be guaranteed to exist.
|
Would you like to resolve the conflicts and we can get this in? |
There, we can merge this now. |
MNThomson
approved these changes
Dec 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a macro to build both the
HxCompletion
slices and the map statically. The tradeoff: anHxCompletion
has its members changed fromString
to&'static str
.