Add hx-disabled-elt attribute #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itepastra
reviewed
Nov 29, 2023
Comment on lines
+228
to
+231
| ( | ||
| "hx-disabled-elt", | ||
| include_str!("./attributes/hx-disabled-elt.md"), | ||
| ), |
There was a problem hiding this comment.
It might be nicer if this has the same formatting as the other elements of the array
There was a problem hiding this comment.
Agreed, but others in the same array, like "hx-select-oob", have the same formatting, so I though might be out of scope for this PR :)
There was a problem hiding this comment.
It might be due to a linear length constraint in an autoformatter.
|
ok, let me review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Htmx 1.9.6 introduced this attribute, used to be an extension (source).
https://htmx.org/attributes/hx-disabled-elt/
Not sure if I should state somewhere that it's only available from 1.9.6? Might be some folks running an older version and may cause confusion. Let me know!