Put the cluster_uuid in quotes (elastic#83987) (elastic#84328)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ThomThomson · Nov 25, 2020 · 9440389 · 9440389
1 parent 40bd49d
commit 9440389
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/x-pack/plugins/monitoring/public/lib/get_safe_for_external_link.test.ts b/x-pack/plugins/monitoring/public/lib/get_safe_for_external_link.test.ts
@@ -51,7 +51,7 @@ describe('getSafeForExternalLink', () => {
         location
       )
     ).toBe(
-      `#/overview?_g=(cluster_uuid:NDKg6VXAT6-TaGzEK2Zy7g,filters:!(),refreshInterval:(pause:!t,value:10000),time:(from:'2017-09-07T20:12:04.011Z',to:'2017-09-07T20:18:55.733Z'))`
+      `#/overview?_g=(cluster_uuid:'NDKg6VXAT6-TaGzEK2Zy7g',filters:!(),refreshInterval:(pause:!t,value:10000),time:(from:'2017-09-07T20:12:04.011Z',to:'2017-09-07T20:18:55.733Z'))`
     );
   });
 
@@ -68,7 +68,7 @@ describe('getSafeForExternalLink', () => {
         location
       )
     ).toBe(
-      `#/overview?_g=(filters:!(),refreshInterval:(pause:!t,value:10000),time:(from:'2017-09-07T20:12:04.011Z',to:'2017-09-07T20:18:55.733Z'),cluster_uuid:NDKg6VXAT6-TaGzEK2Zy7g)`
+      `#/overview?_g=(filters:!(),refreshInterval:(pause:!t,value:10000),time:(from:'2017-09-07T20:12:04.011Z',to:'2017-09-07T20:18:55.733Z'),cluster_uuid:'NDKg6VXAT6-TaGzEK2Zy7g')`
     );
   });
 });
diff --git a/x-pack/plugins/monitoring/public/lib/get_safe_for_external_link.ts b/x-pack/plugins/monitoring/public/lib/get_safe_for_external_link.ts
@@ -24,15 +24,16 @@ export function getSafeForExternalLink(
 
   let newGlobalState = globalStateExecResult[1];
   Object.keys(globalState).forEach((globalStateKey) => {
+    let value = globalState[globalStateKey];
+    if (globalStateKey === 'cluster_uuid') {
+      value = `'${value}'`;
+    }
     const keyRegExp = new RegExp(`${globalStateKey}:([^,]+)`);
     const execResult = keyRegExp.exec(newGlobalState);
     if (execResult && execResult.length) {
-      newGlobalState = newGlobalState.replace(
-        execResult[0],
-        `${globalStateKey}:${globalState[globalStateKey]}`
-      );
+      newGlobalState = newGlobalState.replace(execResult[0], `${globalStateKey}:${value}`);
     } else {
-      newGlobalState += `,${globalStateKey}:${globalState[globalStateKey]}`;
+      newGlobalState += `,${globalStateKey}:${value}`;
     }
   });