-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permitted list of dimension for windmill #47
Conversation
Update windmill branch
Windmill location is checked against the whitelist.
isSiliconLoaded = true; | ||
} | ||
if(Loader.isModLoaded("ProjRed|Core")) | ||
if(Loader.isModLoaded("EnderIO") || Loader.isModLoaded("GalacticraftCore") || Loader.isModLoaded("ProjRed|Core")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a config if we are supporting the mod for community use.
It can be easily done by adding:
if (MekanismConfig.general.enableSiliconCircuitRecipe)
Above
if(Loader.isModLoaded("EnderIO") || Loader.isModLoaded("GalacticraftCore") || Loader.isModLoaded("ProjRed|Core"))
and implement it as a config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already made one lel... not pushed yet
String[] windid = {"0"}; | ||
generators.winddimensionids = Arrays.asList(Mekanism.configuration.getStringList("winddimensionids", "generation", windid, "List of dimension id to be whitelisted")); | ||
dimid = generators.winddimensionids.stream().map(Integer::parseInt).collect(Collectors.toList()); | ||
System.out.println("Windmill whitelist : " + dimid); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should take this debug option before making a release
Other than the nitpick above it looks good. |
No description provided.