Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull'd develop branch #36

Closed
wants to merge 1 commit into from
Closed

Pull'd develop branch #36

wants to merge 1 commit into from

Conversation

Tais993
Copy link
Member

@Tais993 Tais993 commented Sep 8, 2021

Updates JDA (they forgot something with slash-commands, has been added now)

  • Add spotless integration

This hopefully makes formatting more consistent. The Eclipse XML style
was chosen as it is understood by Eclipse, VSC (JDT), Spotless and
mostly by IntelliJ.

  • Make gradelew executable

  • Add "Remove unused imports" setting to spotless

Co-authored-by: Marko Radosavljević marko@radosavljevic.dev

Co-authored-by: I-Al-Istannen i-al-istannen@users.noreply.github.com
Co-authored-by: Marko Radosavljević marko@radosavljevic.dev
Co-authored-by: Jonas jnhrd254@gmail.com

* Bump JDA version to 324 (#31)

Updates JDA (they forgot something with slash-commands, has been added now)

* Add spotless integration

This hopefully makes formatting more consistent. The Eclipse XML style
was chosen as it is understood by Eclipse, VSC (JDT), Spotless and
mostly by IntelliJ.

* Make gradelew executable

* Add "Remove unused imports" setting to spotless

Co-authored-by: Marko Radosavljević <marko@radosavljevic.dev>

* Remove unused imports to fix diffplug/spotless#834 (#35)

Co-authored-by: I-Al-Istannen <i-al-istannen@users.noreply.github.com>
Co-authored-by: Marko Radosavljević <marko@radosavljevic.dev>
Co-authored-by: Jonas <jnhrd254@gmail.com>
@Tais993
Copy link
Member Author

Tais993 commented Sep 8, 2021

Pressed enter unintentionally

@Tais993 Tais993 closed this Sep 8, 2021
@Zabuzard Zabuzard added the release Marks official releases and talks about them, i.e. merges from develop to master label Sep 9, 2021
@Zabuzard Zabuzard added this to the Initial Setup milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Marks official releases and talks about them, i.e. merges from develop to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google-java-format (and removeUnusedImports) broken on JDK 16+ (has workaround)
2 participants