[✅API BACK-COMPAT] Fixed TileCondition functionality #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: `TileCondition` (used by `QueueTask.waitTile(Tile)` does not work correctly. Symptom: `Tile` properties that are used in `Tile.sameAs(Tile)` are `val` thus cannot be changed. When a tile was passed to `TileCondition` as `src`. It seems as though the intention was for `src` to update as a reference the properties update, but the properties will never update, thus rendering `TileCondition` useless. Solution: `TileCondition` now takes `Pawn` and `Tile`, and since `Pawn.tile` is a `var` it means that it changes as `Pawn.tile` changes, and it allows `TileCondition` to work as expected. `QueueTask.waitTile(tile: Tile)` has been changed to `QueueTask.waitTile(tile: Tile, pawn: Pawn = ctx as Pawn)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
TileCondition(used byQueueTask.waitTile(Tile)does not work correctly.Symptom:
Tileproperties that are used inTile.sameAs(Tile)arevalthus cannot be changed. When aTilewas passed toTileConditionassrc. It seems as though the intention was forsrcto update as a reference the properties update, but the properties will never update (because they areval), thus renderingTileConditionuseless.Solution:
TileConditionnow takesPawnandTile(TileCondition(Pawn, Tile)), and sincePawn.tileis avarit means that it changes asPawn.tilechanges, and it allowsTileConditionto work as expected.QueueTask.waitTile(tile: Tile)has been changed toQueueTask.waitTile(tile: Tile, pawn: Pawn = ctx as Pawn)to keep backwards compatibility and preserve previous functionality while also giving the developer a bit more control over whichPawnthey want to reach the tile before continuing the logic.