Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move setEndpointIdentificationAlgorithm inside onSetSSLParametersof #1014

Merged
merged 2 commits into from
May 10, 2020
Merged

Move setEndpointIdentificationAlgorithm inside onSetSSLParametersof #1014

merged 2 commits into from
May 10, 2020

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented May 10, 2020 •
edited
Loading

Description

Hotfix for 1.5.0

Related Issue

Fixes #1011

Motivation and Context

Workaround for Android users
Workaround is documented in our wiki (https://github.com/TooTallNate/Java-WebSocket/wiki/No-such-method-error-'setEndpointIdentificationAlgorithm')

How Has This Been Tested?

Review

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 added this to the Release 1.5.1 milestone May 10, 2020
@marci4 marci4 requested a review from PhilipRoman May 10, 2020 15:10
@marci4 marci4 merged commit 7c07eb7 into TooTallNate:master May 10, 2020
@marci4 marci4 deleted the Issue1011 branch May 10, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipRoman PhilipRoman PhilipRoman approved these changes

Assignees
No one assigned
Labels
Android Bug
Projects
None yet
Milestone
Release 1.5.1
Development

Successfully merging this pull request may close these issues.

Crash on Android due to missing method setEndpointIdentificationAlgorithm on 1.5.0.
2 participants
@marci4 @PhilipRoman