Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include whole invalid status line #589

Merged
merged 1 commit into from
Oct 25, 2017
Merged

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Oct 25, 2017

When a InvalidHandShakeException is thrown, the whole invalid status
line should be included

Description

Included the whole status line which caused the error

Related Issue

#390

Motivation and Context

The exception may not be clear enough without it

How Has This Been Tested?

No test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

When a InvalidHandShakeException is thrown, the whole invalid status
line should be included
@marci4 marci4 added this to the Release 1.3.6 milestone Oct 25, 2017
@marci4 marci4 self-assigned this Oct 25, 2017
@marci4 marci4 merged commit 7df35ff into TooTallNate:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant