Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close WebSocketFactory when updated #769

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Close WebSocketFactory when updated #769

merged 1 commit into from
Sep 10, 2018

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Sep 10, 2018

Description

close() should be called when the WebSocketServerFactory gets updated

Related Issue

Found with #765

Motivation and Context

Bug

How Has This Been Tested?

No test needed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 added this to the Release 1.4.0 milestone Sep 10, 2018
@marci4 marci4 merged commit 872ebf2 into TooTallNate:master Sep 10, 2018
@marci4 marci4 deleted the WebSocketFactory branch September 10, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Server
Projects
None yet
Milestone
Release 1.4.0
Development

Successfully merging this pull request may close these issues.
1 participant
@marci4