Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass on exit code in WebSocketClient close function - fixes bug #827 #846

Merged
merged 1 commit into from
Jan 26, 2019
Merged

Pass on exit code in WebSocketClient close function - fixes bug #827 #846

merged 1 commit into from
Jan 26, 2019

Conversation

Andreas-Bur
Copy link
Contributor

@Andreas-Bur Andreas-Bur commented Jan 23, 2019

Description

In the class WebSocketClient in the close function, I passed the "code" argument on to the "close" call of the WebSocketImpl "engine".

Related Issue

This bug was mentioned in #827.

Motivation and Context

This fixes a bug where the originally supplied CloseFrame code was ignored and the CloseFrame.NORMAL code was passed on instead.

How Has This Been Tested?

All the existing unit tests passed. I manually looked at the implementations of the close function and at the usages of the code argument and came to the conclusion that this change shouldn't have introduced a new issue.
This admittedly small amount of testing should suffice since this is only a minor bug fix that utilises existing functions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PhilipRoman PhilipRoman merged commit 033c27b into TooTallNate:master Jan 26, 2019
@marci4 marci4 added this to the Release 1.4.0 milestone Jan 29, 2019
@Andreas-Bur Andreas-Bur deleted the fix-engine-close branch January 30, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants