Use socket isConnected() method rather than isBound() #964
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is possible that the socket is already bound and not connected. In this case the connection to the server will never happened.
Related Issue
Fixes #962
Motivation and Context
I found this bug in Android context. In this context, I used setSocketFactory method on WebSocketClient with a socket factory which automatically bind created sockets to a defined network interface. In this case WebSocketClient will never connect to the server.
How Has This Been Tested?
A non regression test has been written in tests package (Issue962Test).
The test fails before the correction was applied.
Types of changes
Checklist: