Review: refactor logging_iterator_wrapper

TransitApp · Jun 21, 2019 · 1418f44 · 1418f44
1 parent edaa064
commit 1418f44
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/helpers/logging_iterator_wrapper.js b/helpers/logging_iterator_wrapper.js
@@ -22,12 +22,8 @@ module.exports = (prefix, valueByKey, iteratee) => {
     numberOfKeysDone += 1;
 
     if (Date.now() - lastLogAt > interval && process.env.TEST === undefined) {
-      let percentageDone;
-      if (valueByKey instanceof Array) {
-        percentageDone = (numberOfKeysDone / valueByKey.length) * 100;
-      } else {
-        percentageDone = (numberOfKeysDone / valueByKey.size) * 100;
-      }
+      const numberOfTotalKeys = valueByKey instanceof Array ? valueByKey.length : valueByKey.size;
+      const percentageDone = (numberOfKeysDone / numberOfTotalKeys) * 100;
 
       infoLog(`[${prefix}] ${percentageDone.toPrecision(2)}% done`);