Fix/import export with large files #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvancraen
force-pushed
the
fix/import_export_with_large_files
branch
2 times, most recently
from
438fe7b
to
3f54cbd
Compare
added 3 commits
June 21, 2019 11:49
commented out or else tests takes very long. And unable to push a file larger than 100mb to Github
lvancraen
force-pushed
the
fix/import_export_with_large_files
branch
from
3f54cbd
to
37e3a55
Compare
iliasbhal
reviewed
Jun 21, 2019
iliasbhal
reviewed
Jun 21, 2019
Co-Authored-By: ilias bhallil <ilias.bhal@gmail.com>
iliasbhal
reviewed
Jun 21, 2019
iliasbhal
reviewed
Jun 21, 2019
iliasbhal
reviewed
Jun 21, 2019
Co-Authored-By: ilias bhallil <ilias.bhal@gmail.com>
iliasbhal
reviewed
Jun 21, 2019
gcamp
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Large files aren't able to be stored in memory.
Fix:
Issue
Import: I chunkate the files into 5mb strings so as to parse by chunk instead of the whole file.
Export: I append by row instead of writing the entire file at once.
Notes:
Both of these ways of importing/exporting were used in previous versions of gtfsNodeLib before version 3.5.1 except they used our internal csv parser. So, I reverted back to these old ways except I slightly modified them to use PapaParse.
To think about: