Always call initialRenderCallback, 4.0.0 (#93)

TrueCar · Apr 23, 2019 · d6c5e1b · d6c5e1b
2 parents eef3b5d + 55b05b1
commit d6c5e1b
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-launch-darkly",
-  "version": "3.1.1",
+  "version": "4.0.0",
   "description": "",
   "main": "./build/index",
   "scripts": {

diff --git a/src/components/FeatureFlag.js b/src/components/FeatureFlag.js
@@ -10,8 +10,8 @@ export default function FeatureFlag (props:FeatureFlagType) {
     <LaunchDarklyConsumer>
       {
         (config) => {
-          if (config) {
-            return (<FeatureFlagRenderer {...config} {...props} />);
+          if (config || props.initialRenderCallback) {
+            return (<FeatureFlagRenderer {...(config || {})} {...props} />);
           }
 
           return null;

diff --git a/test/components/FeatureFlag.test.js b/test/components/FeatureFlag.test.js
@@ -58,5 +58,19 @@ describe("components/FeatureFlag", () => {
       const renderer = subject.find(FeatureFlagRenderer);
       expect(renderer).toHaveLength(0);
     });
+    it("renders the initial render callback, even if LD config is absent", () => {
+      const initialRenderCallback = jest
+        .fn()
+        .mockReturnValue(<div>"initial rendered"</div>);
+      mount(
+        <LaunchDarkly>
+          <FeatureFlag
+            {...defaultProps}
+            initialRenderCallback={initialRenderCallback}
+          />
+        </LaunchDarkly>
+      );
+      expect(initialRenderCallback).toHaveBeenCalledTimes(1);
+    });
   });
 });