Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version with promisses #1636

Closed
gabrielrsep opened this issue Sep 14, 2022 · 3 comments
Closed

Version with promisses #1636

gabrielrsep opened this issue Sep 14, 2022 · 3 comments

Comments

@gabrielrsep
Copy link

Summary

I think it would be interesting if there was a version of the database.run(), get() and all() methods that uses Promise instead of callback.
I can send a pull request with these changes, what do you think?

Proposed implementation

the database.run(), get(), and all() methods should be implemented using Promisses

@daniellockyer
Copy link
Member

Hey @SrStick 👋🏻 I would love to see a PR for this 🙂

@RinkAttendant6
Copy link

This appears to be a duplicate of #834

@daniellockyer
Copy link
Member

Good point - closing as a duplicate of #834

@daniellockyer daniellockyer closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants